Replaces OSSpinLock with pthread_mutex_t #1953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pthread_mutex_t is too slow. |
|
libetpan uses pthread_mutex_t too |
|
https://gist.github.com/steipete/36350a8a60693d440954b95ea6cbbafc
In my opnion os_unfair_lock would work.
…On Mon, Sep 5, 2022 at 8:57 AM Artur Protska ***@***.***> wrote:
libetpan uses pthread_mutex_t too
The other alternatives (such as dispatch semaphore or os_unfair_lock) are
not much faster than pthread_mutex_t
—
Reply to this email directly, view it on GitHub
<#1953 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDCGCM4GBXSZ2O5PKSO3V4YKALANCNFSM57PFLEQA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
DINH Viêt Hoà
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1785
pthread_mutex_t was chosen because